Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in-project venv not recognized when not requested #6979

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

finswimmer
Copy link
Member

If a .venv folder exists within the project Poetry uses this if virtualenv.in-project is not explicit set to false. This PR fixes an issue where a in-project folder wasn't listed, if virtualenv.in-project hasn't any explicit value.

Pull Request Check List

Resolves: #3939

  • Added tests for changed code.
  • Updated documentation for changed code.

@finswimmer finswimmer marked this pull request as ready for review November 6, 2022 07:40
@finswimmer finswimmer requested a review from a team November 6, 2022 07:40
@neersighted neersighted changed the title fix: fixed an issue where in-project venv wasn't listed fix: in-project venv not recognized when not requested Nov 6, 2022
@neersighted neersighted enabled auto-merge (squash) November 6, 2022 15:05
@neersighted neersighted merged commit def1ee8 into python-poetry:master Nov 6, 2022
@neersighted neersighted added kind/bug Something isn't working as expected area/venv Related to virtualenv management impact/changelog Requires a changelog entry labels Nov 16, 2022
@neersighted neersighted added this to the 1.3 milestone Nov 16, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/venv Related to virtualenv management impact/changelog Requires a changelog entry kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry env list does not list in-project environment even though it is currently activated
3 participants